Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert curly braces example for nested dictionaries #50180

Merged
merged 1 commit into from Oct 23, 2018

Conversation

Projects
None yet
2 participants
@max-arnold
Copy link
Contributor

commented Oct 23, 2018

What does this PR do?

The snippet in the docs with curly braces for nested dictionaries is incorrect (almost identical to the previous one): https://docs.saltstack.com/en/latest/topics/troubleshooting/yaml_idiosyncrasies.html#nested-dictionaries. The change was introduced in #47860.

This PR reverts the snippet to previous state. I did a test build with make html and sphinx==1.7.9 and found no new warnings.

Commits signed with GPG?

No

@cachedout
Copy link
Collaborator

left a comment

Good catch. Thanks, @max-arnold

@cachedout cachedout merged commit ce341f2 into saltstack:2017.7 Oct 23, 2018

4 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
jenkins/pr/py2-centos-7 running py2-centos-7...
Details
jenkins/pr/py2-windows-2016 running py2-windows-2016...
Details
jenkins/pr/py3-ubuntu-1604 running py3-ubuntu-1604...
Details
jenkins/pr/py3-windows-2016 running py3-windows-2016...
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.