Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testinfra has a python packaging issue that is making version 1.17.0 fail to install some places #50181

Merged
merged 1 commit into from Oct 23, 2018

Conversation

Projects
None yet
3 participants
@cro
Copy link
Member

commented Oct 23, 2018

What does this PR do?

Makes sure we don't try to install testinfra 1.17.0.

What issues does this PR fix or reference?

Collecting testinfra>=1.7.0 (from -r /dev.txt (line 7))
  Downloading https://files.pythonhosted.org/packages/c7/db/1a46e12f5cab12c1b1a29f4ee680f06e1d107a1efd5b4c8769cdbe112558/testinfra-1.17.0.tar.gz (62kB)
    Complete output from command python setup.py egg_info:
    error in testinfra setup command: 'install_requires' must be a string or list of strings containing valid project/version requirement specifiers

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-install-K4VeFO/testinfra/
The command '/bin/sh -c pip2 install -r /dev_python27.txt &&   pip2 install -r /zeromq.txt &&   pip2 install --upgrade 'tornado<5.0'' returned a non-zero code: 1

New Behavior

testinfra installs properly.

Commits signed with GPG?

Yes

@cro cro requested a review from saltstack/team-core as a code owner Oct 23, 2018

@salt-jenkins salt-jenkins requested a review from saltstack/team-suse Oct 23, 2018

@cro cro closed this Oct 23, 2018

@gtmanfred gtmanfred reopened this Oct 23, 2018

@cro cro force-pushed the cro:testinfra-fail branch from c622365 to 7d99787 Oct 23, 2018

@gtmanfred gtmanfred closed this Oct 23, 2018

@gtmanfred gtmanfred reopened this Oct 23, 2018

@gtmanfred gtmanfred merged commit 23e0d40 into saltstack:develop Oct 23, 2018

3 of 10 checks passed

jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has failed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
continuous-integration/jenkins/pr-merge This commit is being built
Details
jenkins/pr/py2-centos-7 running py2-centos-7...
Details
codeclimate All good!
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details

gtmanfred added a commit that referenced this pull request Oct 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.