Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add saltutil state to wrap saltutil.sync* modules #50197

Merged
merged 4 commits into from Oct 30, 2018

Conversation

@mchugh19
Copy link
Contributor

mchugh19 commented Oct 24, 2018

What does this PR do?

Adds saltutil state to wrap the saltutil.sync_* modules.

What issues does this PR fix or reference?

#45264

Previous Behavior

salutil.sync-* was run in states via module.run, and always ran and reported changes

New Behavior

new saltutil.sync_* states properly report if changes occured supporting on_changes

Tests written?

Yes

Christian McHugh added 2 commits Oct 24, 2018
@mchugh19 mchugh19 changed the title add individual syncers and release note add saltutil state to wrap saltutil.sync* modules Oct 24, 2018
Copy link
Collaborator

cachedout left a comment

This is a great idea. I like it.

@cachedout

This comment has been minimized.

Copy link
Collaborator

cachedout commented Oct 25, 2018

Looks like one of these tests does need a fixup though.

@mchugh19

This comment has been minimized.

Copy link
Contributor Author

mchugh19 commented Oct 29, 2018

Corrected state and test

@rallytime rallytime merged commit 686fa69 into saltstack:develop Oct 30, 2018
9 of 11 checks passed
9 of 11 checks passed
jenkins/pr/py2-windows-2016 running py2-windows-2016...
Details
jenkins/pr/py3-windows-2016 running py3-windows-2016...
Details
WIP Ready for review
Details
codeclimate Approved by Mike Place.
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
@max-arnold

This comment has been minimized.

Copy link
Contributor

max-arnold commented Jan 30, 2019

@mchugh19 Are sync_matchers and sync_serializers intentionally missing from the state module?

Also you may want to mention this state module here https://docs.saltstack.com/en/develop/topics/development/modules/#sync-via-the-saltutil-module (these docs were significantly improved in #50633).

@mchugh19

This comment has been minimized.

Copy link
Contributor Author

mchugh19 commented Jan 30, 2019

Nope! I think they are new and didn't exist at the time. So they can be added anytime.

@mchugh19 mchugh19 deleted the mchugh19:saltutil-state branch Jul 4, 2019
mchugh19 added a commit to mchugh19/salt that referenced this pull request Oct 13, 2019
add saltutil state to wrap saltutil.sync* modules
@waynew waynew added this to PR needs port to master in PRs to port to master Oct 17, 2019
@waynew waynew moved this from PR needs port to master to PR has port to master in PRs to port to master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PRs to port to master
  
PR has port to master
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.