add saltutil state to wrap saltutil.sync* modules#50197
Merged
Conversation
mchugh19
changed the title
cachedout
approved these changes
Oct 25, 2018
cachedout
left a comment
cachedout
left a comment
Contributor
There was a problem hiding this comment.
This is a great idea. I like it.
Contributor
|
Looks like one of these tests does need a fixup though. |
Contributor
Author
|
Corrected state and test |
Contributor
|
@mchugh19 Are Also you may want to mention this state module here https://docs.saltstack.com/en/develop/topics/development/modules/#sync-via-the-saltutil-module (these docs were significantly improved in #50633). |
Contributor
Author
|
Nope! I think they are new and didn't exist at the time. So they can be added anytime. |
mchugh19
pushed a commit
to mchugh19/salt
that referenced
this pull request
Oct 13, 2019
add saltutil state to wrap saltutil.sync* modules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds saltutil state to wrap the
saltutil.sync_*modules.What issues does this PR fix or reference?
#45264
Previous Behavior
salutil.sync-*was run in states viamodule.run, and always ran and reported changesNew Behavior
new saltutil.sync_* states properly report if changes occured supporting on_changes
Tests written?
Yes