Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fail if process already ended #50212

Merged
merged 1 commit into from Oct 24, 2018

Conversation

Projects
None yet
2 participants
@dwoz
Copy link
Contributor

commented Oct 24, 2018

What does this PR do?

We can expect the subprocess has already ended by the time we're
checking for child processes. Handle this case gracefully so that tests
do not fail with an exception.

https://jenkinsci.saltstack.com/view/all/job/dwoz-salt-windows-2016-py2/22/testReport/junit/integration.cli.test_batch/BatchTest/test_batch_run/

Tests written?

No - Reduce flakiness in existing tests

Commits signed with GPG?

Yes

Do not fail if process already ended
We can expect the subprocess has already ended by the time we're
checking for child processes. Handle this case gracefully so that tests
do not fail with an exception.

@rallytime rallytime merged commit 6b4e07b into saltstack:2017.7 Oct 24, 2018

8 of 10 checks passed

jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
jenkins/pr/py3-windows-2016 running py3-windows-2016...
Details
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.