Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add various ssh tests to the filemap for salt/utils/vt.py changes #50230

Merged
merged 1 commit into from Oct 25, 2018

Conversation

Projects
None yet
2 participants
@rallytime
Copy link
Contributor

commented Oct 25, 2018

Some of the salt-ssh tests use the salt/utils/vt.py functions. A recent change in that file caused about 90 tests to start failing on the branch.

We need to make sure these tests run when changes to the vt.py util are made in PRs.

Add various ssh tests to the filemap for salt/utils/vt.py changes
Some of the salt-ssh tests use the salt/utils/vt.py functions. A recent
change in that file caused about 90 tests to start failing on the branch.

We need to make sure these tests run when changes to the vt.py util are
made in PRs.

rallytime added a commit to rallytime/salt that referenced this pull request Oct 25, 2018

Don't encode the return values in utils/vt.py
These encodings were causing the salt-ssh tests to fail.

This is a partial revert of saltstack#50146.

In order to see if the tests succeed, PR saltstack#50230 will need to be
merged first.

@cachedout cachedout merged commit 816fa98 into saltstack:develop Oct 25, 2018

4 of 11 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
jenkins/pr/py2-centos-7 running py2-centos-7...
Details
jenkins/pr/py2-ubuntu-1604 running py2-ubuntu-1604...
Details
jenkins/pr/py2-windows-2016 running py2-windows-2016...
Details
jenkins/pr/py3-ubuntu-1604 running py3-ubuntu-1604...
Details
WIP Ready for review
Details
codeclimate All good!
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details

@rallytime rallytime deleted the rallytime:filemap-vt-ssh branch Oct 25, 2018

rallytime added a commit to rallytime/salt that referenced this pull request Oct 25, 2018

Don't encode the return values in utils/vt.py
These encodings were causing the salt-ssh tests to fail.

This is a partial revert of saltstack#50146.

In order to see if the tests succeed, PR saltstack#50230 will need to be
merged first.

cachedout pushed a commit that referenced this pull request Oct 31, 2018

Mike Place
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.