Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't encode the return values in utils/vt.py #50235

Merged
merged 1 commit into from Oct 26, 2018

Conversation

Projects
None yet
3 participants
@rallytime
Copy link
Contributor

commented Oct 25, 2018

These encodings were causing the salt-ssh tests to fail.

This is a partial revert of #50146.

In order to see if the tests succeed completely on a PR, PR #50230 will need to be merged first.

Don't encode the return values in utils/vt.py
These encodings were causing the salt-ssh tests to fail.

This is a partial revert of #50146.

In order to see if the tests succeed, PR #50230 will need to be
merged first.

@rallytime rallytime force-pushed the rallytime:fix-ssh-tests branch from eb0b0be to d86782b Oct 25, 2018

@rallytime

This comment has been minimized.

Copy link
Contributor Author

commented Oct 25, 2018

This issue is no longer blocked as indicated above. It seems I can't remove that blocked designation.

@MTecknology
Copy link
Contributor

left a comment

The originally reported bug is still fixed. Thanks!

@rallytime

This comment has been minimized.

Copy link
Contributor Author

commented Oct 25, 2018

@MTecknology Awesome! Thank you for confirming!

rallytime added a commit to rallytime/salt that referenced this pull request Oct 25, 2018

Fix salt-cloud UnicodeEncodeError when writing to stdout
This is a partial back-port of saltstack#50146.

The full back-port was reverted due to the original change causing all
of the salt-ssh tests to fail.

This change fixes the salt-cloud error, but allows salt-ssh to work
correctly.

Refs saltstack#49523, saltstack#50146, saltstack#50174, saltstack#50231, and saltstack#50235

@rallytime rallytime requested a review from saltstack/team-core Oct 26, 2018

@rallytime rallytime merged commit 3317eb8 into saltstack:develop Oct 26, 2018

9 of 11 checks passed

codeclimate 1 issue to fix
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details

@rallytime rallytime deleted the rallytime:fix-ssh-tests branch Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.