Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing aptly config paths #50267

Merged
merged 1 commit into from Oct 29, 2018

Conversation

Projects
None yet
2 participants
@m03
Copy link
Contributor

commented Oct 28, 2018

What does this PR do?

  • Passes the config_path that was provided to the function that is calling get_repo on to get_repo.
  • Adds a missing CLI example comment.

What issues does this PR fix or reference?

There are no open issues for this. I noticed this omission while working on adding additional functionality to the aptly module.

Previous Behavior

The calls to get_repo were always using the default config path instead of the one provided to the calling function.

New Behavior

The calls to get_repo will now correctly use the config path provided to the calling function.

Tests written?

No

Commits signed with GPG?

Yes

@m03

This comment has been minimized.

Copy link
Contributor Author

commented Oct 29, 2018

The test failures only occurred on the Windows Jenkins jobs and don't appear to be related to my PR.

@rallytime rallytime merged commit 1e8b092 into saltstack:2018.3 Oct 29, 2018

7 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
WIP Ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.