Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issues raised in #47425 for states.netyang #50301

Merged
merged 3 commits into from Oct 30, 2018

Conversation

Projects
None yet
2 participants
@tonybaloney
Copy link
Contributor

commented Oct 30, 2018

What does this PR do?

Fixes an issue with tuple unpacking in the netyang states module.

What issues does this PR fix or reference?

See #47425

Previous Behavior

Remove this section if not relevant

New Behavior

Remove this section if not relevant

Tests written?

Yes

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

tonybaloney added some commits Oct 30, 2018

@rallytime
Copy link
Contributor

left a comment

Thanks @tonybaloney! Nice to see you again. :)

@rallytime rallytime merged commit 412338e into saltstack:develop Oct 30, 2018

11 checks passed

WIP Ready for review
Details
codeclimate All good!
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details

cachedout pushed a commit that referenced this pull request Nov 1, 2018

Mike Place
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.