Add 'noaction' flag for install/remove in the opkg execution module

[rares-pop]

What does this PR do?

Adding the 'noaction' flags when installing/removing software. Basically it's just testing if the operations will succeed or not without actually doing the operation.

Previous Behavior

opkg wasn't providing this functionality.

New Behavior

you can pass the noaction=True flag

Tests written?

Yes

Commits signed with GPG?

Yes

[cachedout]

LGTM

[isbm]

But why? Isn't that we have test=True for this instead?
@cachedout while code looks OK, it is conceptually weird. This should be incorporated with the test=True instead.

[rares-pop]

@isbm - I am not aware of test=True. What is it?

I browsed dpkg.py and apk.py and I haven't seen anything interesting.

Are you saying that we shouldn't go with 'noaction' since that's very opkg specific and say 'test' instead?

[isbm]

@rares-pop this is a test mode, like dry run. This is not really working if module does not respects that (and you also don't know it does respect it or not...). Still this is how Salt is dealing here as of today. Basically, you're looking for __opts__['test'], and if it is there and True, then you no-op. So I would rather drop your own parameter and simply incorporate that path instead. Example you can find here, here, here or here. Or here.

[rares-pop]

@isbm - opts is the minion configuration, right? Can you specify that option (opts['test']) on a salt-call basis?

i.e. the sequence:
salt-call --local pkg.install 'foo'
salt-call --local pkg.install 'bar' test=True
salt-call --local pkg.install 'baz'

[isbm]

@isbm - optsis the minion configuration, right? Can you specify that option (opts['test']) on a salt-call basis?

i.e. the sequence:
salt-call --local pkg.install 'foo'
salt-call --local pkg.install 'bar' test=True
salt-call --local pkg.install 'baz'

Generally, you should be able to incorporate this with the testing mode, described here:
https://docs.saltstack.com/en/latest/ref/states/testing.html

[rares-pop]

@isbm - I don't want to go through state modules. I need to do a simple salt-call --local and pass that argument.

salt-call doesn't seem to put its arguments inside opts, but only in kwargs.

Can you be more specific on how I can achieve that with what you suggest (directly on the minion, possibly a masterless minion)?

[isbm]

First of all, you have to. 😉 It is a virtual module that is also used in states. So if state.apply gets it in test mode, your stuff must cope with it.

Second, if you want that also in the module call it do nothing, then just add **kwargs to the signature (or test=False directly) and use it accordingly, so the test=true mode is still there. Problem is that there is no much of standard so far and we're working to sort this out. However, let's not do another ideological forks. 😉

[rares-pop]

@isbm - sorry for the back and forth, but just to be sure to implement the correct thing:

• salt/modules/opkg.py already has the kwargs in its signatures
• given the current PR, you want me to rename the 'noaction' thing to 'test' and in addition, also check the 'opkg['test']

Is that correct?

If that's correct, if things contradict (opts['test'] = False but kwargs contain test=True'), which should have priority? Probably opts if it's set to true, otherwise kwargs if present?

[isbm]

@isbm - sorry for the back and forth, but just to be sure to implement the correct thing:

• salt/modules/opkg.py already has the kwargs in its signatures

Then just pull "test" out of them:

 if bool(kwargs.get('test') or __opt__.get('test')):
        cmd_prefix.append('--noaction')

[rares-pop]

Oops.. I kept the 'noaction' in the test name, because that's really what it should happen, even if the actual parameter is 'test=True'. More than that, test_install_test sounds weird.

[isbm]

You can call it just _noaction 😉 but this is also OK.