Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back-port #50301 to 2018.3 #50316

Merged
merged 5 commits into from Nov 1, 2018

Conversation

Projects
None yet
3 participants
@rallytime
Copy link
Contributor

commented Oct 30, 2018

Back-port #50301 to 2018.3

tonybaloney added some commits Oct 30, 2018

@cachedout

This comment has been minimized.

Copy link
Collaborator

commented Oct 31, 2018

@rallytime and @tonybaloney Looks like test failures are afoot.

@tonybaloney

This comment has been minimized.

Copy link
Contributor

commented Oct 31, 2018

😕 errr. If I fix this, should I merge it forward to develop or leave it (I think this failure is specific to 2018.3)

@tonybaloney

This comment has been minimized.

Copy link
Contributor

commented Oct 31, 2018

@rallytime 🎁 rallytime#32

Merge pull request #32 from tonybaloney/bp50301
update test assertions
@rallytime

This comment has been minimized.

Copy link
Contributor Author

commented Nov 1, 2018

@tonybaloney Thank you! The fix you made is specific to 2018.3 so no other work is needed here. :)

@cachedout cachedout merged commit 51e333a into saltstack:2018.3 Nov 1, 2018

7 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
WIP Ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details

@rallytime rallytime deleted the rallytime:bp-50301 branch Nov 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.