Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check WinRM port before initiating connection #50329

Merged
merged 1 commit into from Nov 1, 2018

Conversation

Projects
None yet
4 participants
@twangboy
Copy link
Contributor

commented Oct 31, 2018

What does this PR do?

Fixes a timeout issue when connecting to a Windows VM on VMWare (or any other provider for that matter). The connection to WinRM was timing out before the WinRM service was listening on the port. This adds an additional wait on the WinRM port before trying to connect. The default is 15 minutes.

What issues does this PR fix or reference?

#44889

Tests written?

No

Commits signed with GPG?

Yes

@salt-jenkins salt-jenkins requested a review from saltstack/team-cloud Oct 31, 2018

@rallytime rallytime merged commit ab8e845 into saltstack:2017.7 Nov 1, 2018

9 of 10 checks passed

jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details

@twangboy twangboy deleted the twangboy:fix_cloud_winrm branch Nov 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.