Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The driver requires dependency, not the other way around. #50339

Merged
merged 3 commits into from Nov 5, 2018

Conversation

Projects
None yet
3 participants
@bartlaarhoven
Copy link
Contributor

commented Nov 1, 2018

Updated a very annoying (personal opinion) incorrect error message.

What does this PR do?

It fixes the behavior that I got this error message:

Missing dependency: 'shade'. The shade driver requires 'openstack' to be installed.

instead of:

Missing dependency: 'shade'. The openstack driver requires 'shade' to be installed.

What issues does this PR fix or reference?

I haven't created an issue, just fixed it

Previous Behavior

Missing dependency: 'shade'. The shade driver requires 'openstack' to be installed.

New Behavior

Missing dependency: 'shade'. The openstack driver requires 'shade' to be installed.

Tests written?

No

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

The driver requires dependency, not the other way around.
Updated a very annoying (personal opinion) incorrect error message.

@bartlaarhoven bartlaarhoven requested a review from saltstack/team-core as a code owner Nov 1, 2018

@salt-jenkins salt-jenkins requested a review from saltstack/team-suse Nov 1, 2018

@gtmanfred
Copy link
Contributor

left a comment

good catch.

Mike Place and others added some commits Nov 1, 2018

Mike Place

@rallytime rallytime merged commit 4a33b8e into saltstack:develop Nov 5, 2018

3 of 11 checks passed

codeclimate Code Climate is analyzing this code.
Details
jenkins/pr/docs Testing docs...
Details
jenkins/pr/py2-centos-7 running py2-centos-7...
Details
jenkins/pr/py2-ubuntu-1604 running py2-ubuntu-1604...
Details
jenkins/pr/py2-windows-2016 running py2-windows-2016...
Details
jenkins/pr/py3-centos-7 running py3-centos-7...
Details
jenkins/pr/py3-ubuntu-1604 running py3-ubuntu-1604...
Details
jenkins/pr/py3-windows-2016 running py3-windows-2016...
Details
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/lint The lint job has passed
Details

rallytime added a commit that referenced this pull request Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.