Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure logging for ZMQ PubServer daemon #50345

Merged
merged 3 commits into from Nov 2, 2018

Conversation

Projects
None yet
3 participants
@dwoz
Copy link
Contributor

commented Nov 1, 2018

What does this PR do?

Configure logging for ZMQ PubServer daemon.

Previous Behavior

We were not getting logs from the PubServer daemon in the master's log file.

New Behavior

The master log file will contain PubServer logs

Tests written?

No

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@dwoz dwoz requested a review from saltstack/team-core as a code owner Nov 1, 2018

@salt-jenkins salt-jenkins requested review from saltstack/team-transport Nov 1, 2018

@dwoz dwoz requested review from s0undt3ch and rallytime Nov 1, 2018

@rallytime
Copy link
Contributor

left a comment

Very nice!

I definitely want some other people to look at this that in the review list though.

@s0undt3ch
Copy link
Member

left a comment

Solid!

@dwoz

This comment has been minimized.

Copy link
Contributor Author

commented Nov 1, 2018

This doesn't seem to work on windows.

dwoz added some commits Nov 2, 2018

Fix ZMQ PubServer daemon logging works on winndows
Make the api to ZMQ PubServer more similar to tcp pubserver
Fix linter warnings
Fixes "Arguments number differs from overridden 'pre_fork' method'

@dwoz dwoz force-pushed the dwoz:pub_d_logging branch from 1d6c399 to fd58523 Nov 2, 2018

@dwoz

This comment has been minimized.

Copy link
Contributor Author

commented Nov 2, 2018

With the last few commits we are getting the logs on all platforms (including windows).

@dwoz dwoz merged commit 99c8f35 into saltstack:2017.7 Nov 2, 2018

6 of 9 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.