Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2018.3] Fixes to beacon state module #50347

Merged

Conversation

Projects
None yet
3 participants
@garethgreenaway
Copy link
Member

commented Nov 1, 2018

What does this PR do?

Updating the beacon state module to ensure that the format of the bea…con data that is being sent along to the beacon execution module is in the right format.

What issues does this PR fix or reference?

#41342

Previous Behavior

beacon state module did not work due to list based configuration changes.

New Behavior

beacon state module now functions correctly.

Tests written?

Yes

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

garethgreenaway added some commits Nov 1, 2018

Updating the beacon state module to ensure that the format of the bea…
…con data that is being sent along to the beacon execution module is in the right format.

@garethgreenaway garethgreenaway requested a review from saltstack/team-core Nov 1, 2018

garethgreenaway added some commits Nov 1, 2018

Fixing beacon state test. Adding a reset function to beacon module to…
… clear out beacon configuration. Useful for tests runs to ensure bits are left over between runs.

@rallytime rallytime merged commit 3022b7d into saltstack:2018.3 Nov 5, 2018

10 checks passed

WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.