Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase cli batch test timeout for increased reliablity #50359

Merged
merged 1 commit into from Nov 5, 2018

Conversation

Projects
None yet
3 participants
@dwoz
Copy link
Contributor

commented Nov 2, 2018

What does this PR do?

Increase the timeouts in integration.cli.test_batch for better reliability on Windows platforms

Commits signed with GPG?

Yes

@dwoz dwoz force-pushed the dwoz:clitest branch from 0e29eba to 18b5d43 Nov 3, 2018

@damon-atkins

This comment has been minimized.

Copy link
Member

commented Nov 4, 2018

This indicates a fix is required or a design change is required to support the slower to respond windows minions.

    if salt.utils.is_windows():
        run_timeout = 90
    else:
        run_timeout = 30

@rallytime rallytime merged commit 6472100 into saltstack:2017.7 Nov 5, 2018

7 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
WIP Ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.