Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect change reporting in acme.cert #50400

Merged
merged 1 commit into from Nov 6, 2018

Conversation

@xuhcc
Copy link
Contributor

commented Nov 6, 2018

What issues does this PR fix or reference?

#50310

Tests written?

No

Commits signed with GPG?

No

Fixes #50310
@cachedout cachedout merged commit 2505f8d into saltstack:develop Nov 6, 2018
10 of 11 checks passed
10 of 11 checks passed
jenkins/pr/py3-windows-2016 running py3-windows-2016...
Details
WIP Ready for review
Details
codeclimate All good!
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
@cachedout

This comment has been minimized.

Copy link
Collaborator

commented Nov 6, 2018

Nice catch here, @xuhcc. Thank you for the fix.

@xuhcc

This comment has been minimized.

Copy link
Contributor Author

commented Nov 6, 2018

@cachedout Oh, there was a typo :(

I've created additional PR #50402

twangboy added a commit that referenced this pull request May 10, 2019
Backport #50400 and #50402 into 2019.2.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.