Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git_pillar: Add tests for root parameter #50407

Merged
merged 1 commit into from Nov 7, 2018

Conversation

Projects
None yet
3 participants
@sathieu
Copy link
Contributor

commented Nov 7, 2018

What does this PR do?

git_pillar: Add tests for root parameter

What issues does this PR fix or reference?

Tests written?

Yes. Coverage increased.

Note: I've not tested the destructive tests.

Commits signed with GPG?

Yes

@sathieu sathieu force-pushed the sathieu:git_pillar-test-root-param branch from 9f74805 to 2e88b74 Nov 7, 2018

@sathieu

This comment has been minimized.

Copy link
Contributor Author

commented Nov 7, 2018

The failure on win2016 seems unrelated:

07:17:10        ============================  Overall Tests Report  ============================
07:17:10        *** integration.modules.test_sysmod Tests  *************************************
07:17:10         --------  Tests with Errors  --------------------------------------------------
07:17:10           -> integration.modules.test_sysmod.SysModuleTest.test_valid_docs  ...........
07:17:10        Traceback (most recent call last):
07:17:10          File "c:\users\admini~1\appdata\local\temp\kitchen\testing\tests\integration\modules\test_sysmod.py", line 29, in test_valid_docs
07:17:10            '\n'.join(['  - {0}'.format(f) for f in ret['missing_docstring']]),
07:17:10        TypeError: 'bool' object is not subscriptable

@rallytime rallytime requested a review from terminalmage Nov 7, 2018

@rallytime rallytime merged commit 5dceafb into saltstack:develop Nov 7, 2018

10 of 11 checks passed

jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
WIP Ready for review
Details
codeclimate All good!
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details

@sathieu sathieu deleted the sathieu:git_pillar-test-root-param branch Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.