Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use exc.winerror not exc[0] to avoid python3 TypeError #50414

Merged

Conversation

Projects
None yet
3 participants
@flassman
Copy link

commented Nov 7, 2018

Fixes #50413

What does this PR do?

python3 does not provide an exc[] dict to access the error details, so instead we need to use the winerror attribute

The whole problem is gone with the HEAD due to refactoring of that module, but it would be really cool if these two lines could be merged to at least 2018.3 so that any future 2018.3.x would not break our manually fixed minions again

What issues does this PR fix or reference?

Fixes #50413

Previous Behavior

Remove this section if not relevant

New Behavior

Remove this section if not relevant

Tests written?

No

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@salt-jenkins salt-jenkins requested a review from saltstack/team-windows Nov 7, 2018

@cachedout

This comment has been minimized.

Copy link
Collaborator

commented Nov 7, 2018

@dwoz Can you please look at this?

@dwoz

dwoz approved these changes Nov 7, 2018

@cachedout cachedout merged commit 1e72d20 into saltstack:2017.7 Nov 8, 2018

7 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
WIP Ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.