Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing an issue on mac_system where the virtual function wouldnt load #50421

Merged
merged 1 commit into from Nov 7, 2018

Conversation

Projects
None yet
2 participants
@weswhet
Copy link
Contributor

commented Nov 7, 2018

What does this PR do?

fixes #50420, a lot of code in this module is calling the mac_utils module directly not using the __utils__ dunder dictionary, I've swapped the behavior and it seems to resolve the issue.

What issues does this PR fix or reference?

#50420

Tests written?

Yes, old tests still work fine.

Commits signed with GPG?

Yes

cc @Ch3LL @sheagcraig

@garethgreenaway garethgreenaway self-requested a review Nov 7, 2018

@garethgreenaway garethgreenaway merged commit fccf875 into saltstack:2018.3 Nov 7, 2018

10 checks passed

WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details

@weswhet weswhet deleted the weswhet:fix-mac_system-loader branch Nov 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.