Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2018.3] Fixes to sysctl modules and state #50423

Merged

Conversation

Projects
None yet
2 participants
@garethgreenaway
Copy link
Member

commented Nov 8, 2018

What does this PR do?

Adding a check to see if the config file exists, if not then return an empty list so we get the would be changes. Adding a test for this functionality.

What issues does this PR fix or reference?

#50292

Previous Behavior

When run with test=True, if the file did not exist then a log message would say that the file could not be opened.

New Behavior

Updated the linux & freebsd sysctl modules to return an empty list when the file does not exist, then we get the would be changes.

Tests written?

Yes

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

garethgreenaway added some commits Nov 7, 2018

Adding a check to see if the config file exists, if not then return a…
…n empty list so we get the would be changes. Adding a test for this functionality.

@garethgreenaway garethgreenaway requested review from rallytime and saltstack/team-core Nov 8, 2018

@rallytime rallytime merged commit e9464c9 into saltstack:2018.3 Nov 8, 2018

9 of 10 checks passed

jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.