Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git_pillar: Add tests for mountpoint parameter #50425

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@sathieu
Copy link
Contributor

commented Nov 8, 2018

What does this PR do?

git_pillar: Add tests for mountpoint parameter

What issues does this PR fix or reference?

Tests written?

Yes

Commits signed with GPG?

Yes

@sathieu sathieu force-pushed the sathieu:test-mountpoint branch 2 times, most recently from d6b7d28 to 2ce412a Nov 8, 2018

@sathieu

This comment has been minimized.

Copy link
Contributor Author

commented Nov 8, 2018

I plan to backport #50378, #50407 and this one to 2018.03.

My target is to fix #50364.

@sathieu sathieu force-pushed the sathieu:test-mountpoint branch from 2ce412a to 6e2f4e4 Nov 8, 2018

@cachedout

This comment has been minimized.

Copy link
Collaborator

commented Nov 20, 2018

@sathieu There are some merge conflicts here. Can you please resolve them?

@cachedout cachedout requested a review from terminalmage Nov 20, 2018

@sathieu

This comment has been minimized.

Copy link
Contributor Author

commented Nov 21, 2018

It has been backported to 2018.3 as #50427.

I thought it would be forward ported as part of 2018.3 to develop regular merge.

@terminalmage

This comment has been minimized.

Copy link
Contributor

commented Nov 21, 2018

@sathieu In that case, I think we can close this since #50427 was merged.

@sathieu

This comment has been minimized.

Copy link
Contributor Author

commented Nov 21, 2018

OK. Thanks.

@sathieu sathieu closed this Nov 21, 2018

@sathieu sathieu deleted the sathieu:test-mountpoint branch Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.