Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two bugfixes #50456

Merged
merged 4 commits into from Nov 13, 2018

Conversation

Projects
None yet
2 participants
@terminalmage
Copy link
Contributor

commented Nov 9, 2018

  1. TimedProc doesn't properly handle commands passed as a list of arguments when shell=True. This was broken in 1f7d50d.

  2. unless/onlyif now supports a list of commands for git states

Fixes #50218

terminalmage added some commits Nov 8, 2018

TimedProc: Don't assume args is a string
Both a string and a list of args are supported
@dwoz

dwoz approved these changes Nov 10, 2018

@terminalmage

This comment has been minimized.

Copy link
Contributor Author

commented Nov 12, 2018

I'm going to add a unit test for the TimedProc regression.

@terminalmage

This comment has been minimized.

Copy link
Contributor Author

commented Nov 12, 2018

Test added

@dwoz dwoz merged commit 7dd3438 into saltstack:2018.3 Nov 13, 2018

10 checks passed

WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details

@terminalmage terminalmage deleted the terminalmage:issue50218 branch Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.