Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More reliable pub server publishing #50463

Merged
merged 5 commits into from Nov 26, 2018

Conversation

Projects
None yet
8 participants
@dwoz
Copy link
Contributor

commented Nov 11, 2018

  • Uses existing zmq context
  • Store socket in thread local storage for re-use
  • Add tests to verify publish reliability

What issues does this PR fix or reference?

#36469
#46553
#50393

Tests written?

Yes

Commits signed with GPG?

Yes

@salt-jenkins salt-jenkins requested a review from saltstack/team-transport Nov 11, 2018

More reliable pub server publishing
- Uses existing zmq context
- Store socket in thread local storage for re-use
- Add tests to verify publish reliability

@dwoz dwoz force-pushed the dwoz:zmqpubserv branch from 7c88fda to 6882209 Nov 11, 2018

@dwoz

This comment has been minimized.

Copy link
Contributor Author

commented Nov 11, 2018

This PR replaces the work done in #50424

@dwoz dwoz requested review from DmitryKuzmenko, isbm, s0undt3ch and cachedout Nov 11, 2018

@DmitryKuzmenko
Copy link
Contributor

left a comment

👍 🥇

@cachedout

This comment has been minimized.

Copy link
Collaborator

commented Nov 13, 2018

@skizunov @rares-pop or @jacksontj Do any of you have interest in looking at this?

@rares-pop
Copy link
Contributor

left a comment

@cachedout - yeah, it looks good! It's nice we are caching the socket.

Show resolved Hide resolved salt/transport/zeromq.py
Show resolved Hide resolved salt/transport/zeromq.py
Show resolved Hide resolved salt/transport/zeromq.py
Show resolved Hide resolved salt/transport/zeromq.py
@isbm
Copy link
Contributor

left a comment

I have few points here, maybe you could look at them. Also you seems wrote almost pure integration tests, since they are not looking how code logic works but how different pieces are working together. I would suggest to move them away to the integration tests part and do not call them unit tests.

Show resolved Hide resolved salt/transport/zeromq.py
Show resolved Hide resolved salt/transport/zeromq.py
Show resolved Hide resolved salt/transport/zeromq.py
Show resolved Hide resolved tests/unit/transport/test_zeromq.py
Show resolved Hide resolved tests/unit/transport/test_zeromq.py
Show resolved Hide resolved tests/unit/transport/test_zeromq.py

dwoz added some commits Nov 15, 2018

@cachedout cachedout merged commit b2cf134 into saltstack:2017.7 Nov 26, 2018

10 checks passed

WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.