Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use patched version of test-kitchen until next upstream release #50467

Merged
merged 1 commit into from Nov 12, 2018

Conversation

Projects
None yet
2 participants
@dwoz
Copy link
Contributor

commented Nov 11, 2018

What does this PR do?

Point test-kitchen at my bug fix branch until next test-kitchen release so we can configure the winrm receive_timeout option.

What issues does this PR fix or reference?

We're seeing [execution expired] exceptions from test kitchen in our Windows test suites. Point test-kitchen at my bug fix branch for upstream issue test-kitchen 1331.

@dwoz dwoz requested review from gtmanfred and dubb-b Nov 11, 2018

@dwoz dwoz changed the title Use patched version of test-kitchen until next release Use patched version of test-kitchen until next upstream release Nov 11, 2018

@dubb-b

This comment has been minimized.

Copy link

commented Nov 12, 2018

@dwoz We need to update the gems in each kitchen node after this correct?

@dwoz

This comment has been minimized.

Copy link
Contributor Author

commented Nov 12, 2018

@dubb-b I don't think we need to do anything special here since Jenkins runs a bundle install before starting the kitchen builds. Am I missing something?

@dubb-b

This comment has been minimized.

Copy link

commented Nov 12, 2018

@dwoz I have seen the version cache. may have to clear out the .gems folder. Im not quite sure. We can let it go and see if there are issues afterward.

@dubb-b

dubb-b approved these changes Nov 12, 2018

@dwoz dwoz merged commit e5f97cd into saltstack:2017.7 Nov 12, 2018

10 checks passed

WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.