Allow to specify used trustmodel in gpg.verify - #50474
Merged
Merged
Conversation
Contributor
|
@kyuubii it looks like there are 0 unit and/or integration tests for this module. How do you feel about adding one, either unit or integration? |
dwoz
self-requested a review
November 13, 2018 09:39
cachedout
approved these changes
Nov 13, 2018
Contributor
Author
|
It looks like the following failing test |
kyuubii
force-pushed
the
gpg-trust-model
branch
3 times, most recently
from
November 15, 2018 12:49
b803a0f to
bca14b2
Compare
kyuubii
force-pushed
the
gpg-trust-model
branch
from
November 15, 2018 12:52
bca14b2 to
3d7a4d5
Compare
Contributor
Author
Due to our current time constraints, I won't get around to provide unit or even integration tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It allows to explicitly specify the trust model used by
gpg.verify, such asdirectortofu+pgpWhat issues does this PR fix or reference?
None
Previous Behavior
gpg.verifyalways used the trust model implicitly defined by python-gnupg/GnuPGNew Behavior
The previous behaviour can be overridden by explicitly providing a trust model.
Tests written?
No
Commits signed with GPG?
Yes