Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify used trustmodel in `gpg.verify` #50474

Merged
merged 1 commit into from Nov 20, 2018

Conversation

Projects
None yet
3 participants
@kyuubii
Copy link
Contributor

commented Nov 12, 2018

What does this PR do?

It allows to explicitly specify the trust model used by gpg.verify, such as direct or tofu+pgp

What issues does this PR fix or reference?

None

Previous Behavior

gpg.verify always used the trust model implicitly defined by python-gnupg/GnuPG

New Behavior

The previous behaviour can be overridden by explicitly providing a trust model.

Tests written?

No

Commits signed with GPG?

Yes

@dwoz

This comment has been minimized.

Copy link
Contributor

commented Nov 13, 2018

@kyuubii it looks like there are 0 unit and/or integration tests for this module. How do you feel about adding one, either unit or integration?

@dwoz dwoz self-requested a review Nov 13, 2018

@kyuubii

This comment has been minimized.

Copy link
Contributor Author

commented Nov 15, 2018

It looks like the following failing test jenkins/pr/py2-centos-7 is not related to this pull request (psutil.NoSuchProcess process no longer exists (pid=16777)).

@kyuubii kyuubii force-pushed the kyuubii:gpg-trust-model branch 3 times, most recently from b803a0f to bca14b2 Nov 15, 2018

@kyuubii kyuubii force-pushed the kyuubii:gpg-trust-model branch from bca14b2 to 3d7a4d5 Nov 15, 2018

@kyuubii

This comment has been minimized.

Copy link
Contributor Author

commented Nov 15, 2018

@kyuubii it looks like there are 0 unit and/or integration tests for this module. How do you feel about adding one, either unit or integration?

Due to our current time constraints, I won't get around to provide unit or even integration tests.

@cachedout cachedout merged commit e86ea9c into saltstack:fluorine Nov 20, 2018

6 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/docs The docs job has failed
Details
jenkins/pr/lint The lint job has failed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
WIP Ready for review
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.