Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load beacon fix #50514

Merged
merged 4 commits into from Nov 14, 2018

Conversation

Projects
None yet
2 participants
@bornwitbugs
Copy link
Contributor

commented Nov 14, 2018

What does this PR do?

Fix a typo in the load beacon and adds the options to the existing test to catch such things in the future.

What issues does this PR fix or reference?

#48343

Previous Behavior

Typo caused load beacon to fail and tests did not pick it up because those options were not passed in the test version

New Behavior

Fixed typo and include additional beacon options in test to catch future typos.

Tests written?

Yes

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

bornwitbugs added some commits Nov 2, 2018

fixing type in load beacon module and adding option validators to con…
…fig check function along with mock default values in test
fixing type in load beacon module and adding option validators to con…
…fig check function along with mock default values in test, fixes #48343

@rallytime rallytime requested a review from garethgreenaway Nov 14, 2018

@garethgreenaway garethgreenaway merged commit fa2f4a5 into saltstack:2018.3 Nov 14, 2018

9 of 10 checks passed

jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details

@bornwitbugs bornwitbugs deleted the bornwitbugs:load_beacon_fix branch Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.