Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tag to ec2 cloud tests #50532

Merged
merged 1 commit into from Nov 16, 2018

Conversation

Projects
None yet
3 participants
@dubb-b
Copy link

commented Nov 15, 2018

What does this PR do?

This adds a tag to the EC2 instance that the cloud integration tests run. We use this tag for cleaning up the environment if something in the test suite fails or aborts.

What issues does this PR fix or reference?

Enhancement to the current functionality

Tests written?

No

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

Brett Benassi

@dubb-b dubb-b requested a review from Ch3LL Nov 15, 2018

@dwoz

dwoz approved these changes Nov 16, 2018

@Ch3LL

Ch3LL approved these changes Nov 16, 2018

@Ch3LL Ch3LL merged commit edd9738 into saltstack:2017.7 Nov 16, 2018

7 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
WIP Ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.