Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurefs: gracefully handle AttributeError #50567

Merged
merged 2 commits into from Nov 19, 2018

Conversation

@rombert
Copy link
Contributor

commented Nov 19, 2018

What does this PR do?

It is possible that the azure.storage object has no version defined.
In that case, prevent console spam with unhandled AttributeError
messages and instead consider that Azure support is not present.

Problem was encountered on openSUSE Tumbleweed.

What issues does this PR fix or reference?

#50535

Tests written?

No, I am not sure how to add that though.

Commits signed with GPG?

Yes

It is possible that the azure.storage object has no __version__ defined.
In that case, prevent console spam with unhandled AttributeError
messages and instead consider that Azure support is not present.

Problem was encountered on openSUSE Tumbleweed.
@rombert rombert force-pushed the rombert:develop branch from c18c8bf to fdc4dec Nov 19, 2018
@rombert

This comment has been minimized.

Copy link
Contributor Author

commented Nov 19, 2018

There are some tests failing, but I'm not sure how they are related to my change. I see things like

        --------  Failed Tests  -------------------------------------------------------
          -> integration.proxy.test_simple.ProxyMinionSimpleTestCase.test_can_it_ping  
       Traceback (most recent call last):
         File "/tmp/kitchen/testing/tests/integration/proxy/test_simple.py", line 22, in test_can_it_ping
           self.assertEqual(ret, True)
       AssertionError: False != True
          .............................................................................
          -> integration.proxy.test_simple.ProxyMinionSimpleTestCase.test_service_get_all  
       Traceback (most recent call last):
         File "/tmp/kitchen/testing/tests/integration/proxy/test_simple.py", line 73, in test_service_get_all
           self.assertTrue(ret)
       AssertionError: False is not true
          .............................................................................
          -> integration.proxy.test_simple.ProxyMinionSimpleTestCase.test_service_start  
       Traceback (most recent call last):
         File "/tmp/kitchen/testing/tests/integration/proxy/test_simple.py", line 69, in test_service_start
           self.assertTrue(ret)
       AssertionError: False is not true
          .............................................................................

I'd be happy to correct them, but I need some guidance.

@cachedout

This comment has been minimized.

Copy link
Collaborator

commented Nov 19, 2018

@rombert Those test failures are artifacts or an unrelated change. This looks fine. Thanks!

@cachedout cachedout merged commit 09ba674 into saltstack:develop Nov 19, 2018
8 of 11 checks passed
8 of 11 checks passed
jenkins/pr/py2-windows-2016 running py2-windows-2016...
Details
jenkins/pr/py3-centos-7 running py3-centos-7...
Details
jenkins/pr/py3-windows-2016 running py3-windows-2016...
Details
WIP Ready for review
Details
codeclimate All good!
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
@rombert

This comment has been minimized.

Copy link
Contributor Author

commented Nov 19, 2018

Thanks for the quick review + merge @cachedout !

dwoz added a commit that referenced this pull request Aug 13, 2019
Cherry Pick #50567 and #53238 into 2019.2.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.