Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2018.3] Adding test=True to artifactory.download. #50580

Conversation

Projects
None yet
3 participants
@garethgreenaway
Copy link
Member

commented Nov 20, 2018

What does this PR do?

Adding test=True to artifactory.download.

What issues does this PR fix or reference?

#50155 #50558

Previous Behavior

test=True was previously ignored

New Behavior

If test=True then we don't download the artifact but return a message of what would be downloaded.

Tests written?

Yes

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@garethgreenaway garethgreenaway requested a review from saltstack/team-core Nov 20, 2018

@cachedout cachedout merged commit 735c9f4 into saltstack:2018.3 Nov 20, 2018

10 checks passed

WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
@angeloudy

This comment has been minimized.

Copy link
Contributor

commented on 3661ee0 Apr 4, 2019

If changes always return empty, what's the point to have test=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.