Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix lint only changes, full lint on merge forwards #50583
What does this PR do?
What issues does this PR fix or reference?
@cachedout if you change your mind please let me know. The full lint would only run on a merge forward PR and only if the changes passes. It may be handy to have it run only in that case. I'd like your or @saltstack/team-core 's input here.
lint has coding rules, which change from one release to the next. The idea is to try and make sure those changes are picked up. Hence it only happens if the branch starts with
Happy to pull the code. Just thought it might help the quality of the releases.
The original code which listed out the changes detected "files out of date" when a branch is old. This is fixed in this PR after running some experiments to determine the best git diff args to use.
One choice is to try it out and pull code if it becomes an issue to the merge forward process.
I have assume that a full lint will take less time than all the other tests what are run, so their should be no delays.