Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the supervisord.dead state idempotency #50605

Merged
merged 3 commits into from Nov 27, 2018

Conversation

Projects
None yet
3 participants
@Oloremo
Copy link
Contributor

commented Nov 21, 2018

What does this PR do?

Added quick return in supervisord.dead state to enforce idempotency is the supervisord service is not exists.

What issues does this PR fix or reference?

Fixes #50601

Previous Behavior

supervisord.dead state wasn't idempotent in case of non-existed service.

New Behavior

supervisord.dead state is idempotent in case of non-existed service.

Tests written?

No

Commits signed with GPG?

Yes

Oloremo added some commits Nov 21, 2018

@Oloremo

This comment has been minimized.

Copy link
Contributor Author

commented Nov 22, 2018

No idea why windows test failed, can someone advise what I need to do now?

@cachedout

This comment has been minimized.

Copy link
Collaborator

commented Nov 23, 2018

@saltstack/team-windows can any of you help out here?

@dwoz

dwoz approved these changes Nov 27, 2018

@dwoz dwoz merged commit 15bf09a into saltstack:2017.7 Nov 27, 2018

10 checks passed

WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.