Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't squash tracebacks and Unicode fixes #50619

Merged
merged 2 commits into from Nov 26, 2018

Conversation

Projects
None yet
3 participants
@s0undt3ch
Copy link
Member

commented Nov 23, 2018

What does this PR do?

Fixes two code paths which squashed the traceback and also fixes a code path which didn't handle unicode

PS: Please excuse the caps.

Tests written?

No

Commits signed with GPG?

Yes

s0undt3ch added some commits Nov 23, 2018

@salt-jenkins salt-jenkins requested a review from saltstack/team-state Nov 23, 2018

@cachedout
Copy link
Collaborator

left a comment

Nice find.

@cachedout cachedout merged commit 14c4fd5 into saltstack:2018.3 Nov 26, 2018

10 checks passed

WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
@s0undt3ch

This comment has been minimized.

Copy link
Member Author

commented Nov 26, 2018

Should this also go into 2017.x?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.