Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Better handle errors in entry points #50632
What does this PR do?
Fixes entry point loading, so that if it fails, the exception is logged instead of propagated to the larger system.
What issues does this PR fix or reference?
The minion would fail to start if there was any kind of problem with entry point loading.
The exception is logged instead.
No, and I'm not sure how or where.
Commits signed with GPG?
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.
I found problems where if you have a bad entry point declared (in my case, because of copy/paste errors and then the code wasn't being packaged), then salt won't start. There's also weird things that happen if there's a problem in the called function.
You probably hadn't heard of anyone encountering this problem because this feature is completely undocumented (see #50633) and nobody has used it as far as I know. (Except now, because this is super helpful for my own projects.)