Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle pipenv like version restrictions #50639

merged 1 commit into from Nov 26, 2018


None yet
4 participants
Copy link

commented Nov 26, 2018

We need to handle python_version filters in requirement files in order
to install cleanly using pip

What does this PR do?

Filter requirements from install_requires which do not match the current python version.

What issues does this PR fix or reference?

Resolves issue #50403

Previous Behavior

Installing salt using pip install would fail on pyzmq and tornado dependencies depending on your python version.

Tests written?

Yes - added doctests for the tricky parts, they won't run in the normal test suite but at least people can run them if they need to fix a bug.

Commits signed with GPG?


Handle pipenv like version restrictions
We need to handle python_version filters in requirement files in order
to install cleanly using pip

@dwoz dwoz requested review from twangboy and gtmanfred Nov 26, 2018

@cachedout cachedout merged commit 20a2de3 into saltstack:2018.3 Nov 26, 2018

10 checks passed

WIP Ready for review
continuous-integration/jenkins/pr-merge This commit looks good
jenkins/pr/docs The docs job has passed
jenkins/pr/lint The lint job has passed
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.