Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2017.7] fixes to gem state when using greater than or less than versions #50659

Conversation

Projects
None yet
2 participants
@garethgreenaway
Copy link
Member

commented Nov 27, 2018

What does this PR do?

When using the gem installed state, when passing a version that includes greater than or less than symbols, ensure that the installed versions meets that requirement.

What issues does this PR fix or reference?

#49954

Previous Behavior

Greater than, less than, etc. symbols are basically ignored and Salt state will continue attempting to install the gem.

New Behavior

Ensure the installed version is greater than or less than desired version if appropriate symbols are provided.

Tests written?

Yes

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@garethgreenaway garethgreenaway requested a review from saltstack/team-core Nov 27, 2018

When using the gem installed state, when passing a version that inclu…
…des greater than or less than symbols, ensure that the installed versions meets that requirement.

@garethgreenaway garethgreenaway force-pushed the garethgreenaway:49954_gem_installed_less_than_greater_than_support branch from f73794e to 0ec8bcf Nov 27, 2018

@cachedout cachedout merged commit 1236b51 into saltstack:2017.7 Nov 28, 2018

8 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit is being built
Details
jenkins/pr/py2-windows-2016 running py2-windows-2016...
Details
WIP Ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.