Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2017.7] fixes to file.replace with search_only #50672

Conversation

Projects
None yet
2 participants
@garethgreenaway
Copy link
Member

commented Nov 28, 2018

What does this PR do?

When using file.replace, with the search_only option, if the pattern does not exist in the file then we should return False.

What issues does this PR fix or reference?

#49691

Tests written?

Yes

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@garethgreenaway garethgreenaway requested a review from saltstack/team-core Nov 28, 2018

@garethgreenaway garethgreenaway force-pushed the garethgreenaway:49691_file_replace_search_only_return_false branch from 16060c8 to 77fc8cf Nov 28, 2018

garethgreenaway added some commits Nov 28, 2018

When using file.replace, with the search_only option, if the pattern …
…does not exist in the file then we should return False.

@garethgreenaway garethgreenaway force-pushed the garethgreenaway:49691_file_replace_search_only_return_false branch from 6c30349 to 7e7df06 Nov 28, 2018

@garethgreenaway garethgreenaway changed the title [2017.7] [2017.7] fixes to file.replace with search_only Nov 28, 2018

@garethgreenaway garethgreenaway merged commit 6dc3afc into saltstack:2017.7 Nov 28, 2018

9 of 10 checks passed

jenkins/pr/py3-windows-2016 running py3-windows-2016...
Details
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.