Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2018.3] Fixes to acme module when adding aliases to existing certificate #50683

Conversation

Projects
None yet
2 participants
@garethgreenaway
Copy link
Member

commented Nov 29, 2018

What does this PR do?

When adding alises to an existing Certbot certificate, if we see a message about expanding in the stderr returned from cmd.run_all we should rerun the cmd with --expand included.

What issues does this PR fix or reference?

#48759

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

When adding alises to an existing Certbot certificate, if we see a me…
…ssage about expanding in the stderr returned from cmd.run_all we should rerun the cmd with --expand included.

@garethgreenaway garethgreenaway requested a review from saltstack/team-core Nov 29, 2018

@cachedout
Copy link
Collaborator

left a comment

LGTM

@cachedout cachedout merged commit b604785 into saltstack:2018.3 Nov 29, 2018

9 of 10 checks passed

jenkins/pr/py3-windows-2016 running py3-windows-2016...
Details
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.