Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes/Improvements to ci/lint. #50702

Merged
merged 1 commit into from Dec 1, 2018

Conversation

Projects
None yet
3 participants
@damon-atkins
Copy link
Member

commented Nov 30, 2018

What does this PR do?

Ensure archiveArtifacts are collected on failure as well.
Use CHANGE_BRANCH to detect merge forwards.

@damon-atkins damon-atkins requested a review from saltstack/team-core as a code owner Nov 30, 2018

@cachedout cachedout requested a review from dubb-b Nov 30, 2018

@dubb-b

dubb-b approved these changes Nov 30, 2018

@dubb-b

This comment has been minimized.

Copy link

commented Nov 30, 2018

@damon-atkins

This comment has been minimized.

Copy link
Member Author

commented Dec 1, 2018

Good. just need someone from @saltstack/team-core to approve and merge.

@garethgreenaway garethgreenaway merged commit 979b3aa into saltstack:2017.7 Dec 1, 2018

8 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit is being built
Details
jenkins/pr/py3-centos-7 running py3-centos-7...
Details
WIP Ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.