Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report salt-call exit code from ssh_py_shim.py #50733

Merged
merged 1 commit into from Dec 6, 2018

Conversation

Projects
None yet
2 participants
@marmarek
Copy link
Contributor

commented Dec 4, 2018

What does this PR do?

Fix error reporting if salt-call called from ssh_py_shim.py fails to run.

What issues does this PR fix or reference?

Fixes #50727

Previous Behavior

salt-call exit code ignored by ssh_py_shim.py, always 0 returned.

New Behavior

ssh_py_shim.py exits with salt-call exit code.

Tests written?

No

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@marmarek marmarek force-pushed the marmarek:patch-3 branch from 9b990ee to 1011421 Dec 4, 2018

@cachedout cachedout merged commit cb85d5d into saltstack:2017.7 Dec 6, 2018

8 of 10 checks passed

jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
@cachedout

This comment has been minimized.

Copy link
Collaborator

commented Dec 6, 2018

Looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.