Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grafana dashboard updating when nothing has changed #50745

Merged
merged 1 commit into from Dec 4, 2018

Conversation

Projects
None yet
2 participants
@bbinet
Copy link
Contributor

commented Dec 4, 2018

What does this PR do?

Fix grafana dashboard update

What issues does this PR fix or reference?

No existing issue in bug tracker.

Previous Behavior

grafana4_dashboard.present state would always report a dashboard update even if nothing has changed.

New Behavior

grafana4_dashboard.present state now report a dashboard update only if something has actually changed.

Tests written?

No

Commits signed with GPG?

No

Fix grafana dashboard updating when nothing has changed
The new field "uid" (from grafana5) must be ignored: it will always
differ as it is generated server side by grafana when creating the
dashboard.
@dwoz

dwoz approved these changes Dec 4, 2018

@dwoz dwoz merged commit c02387e into saltstack:2018.3 Dec 4, 2018

9 checks passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details

@bbinet bbinet deleted the bbinet:fix-grafana-dashboard-update branch Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.