Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixes a memory leak which is caused by un-cleared stream connections. #50752
What does this PR do?
Compliment memory leak fixes of #46094.
Previous versions of tornado (4.4.x) do gc frequently for asynchronous request handlers' variables, but the current version of tornado (5.x) don't do gc well for the variables.
The reason that gc should be run appropriately is that the
What issues does this PR fix or reference?
(Logging by following code at
Maintains the stream size and the read-write buffer size.
Commits signed with GPG?
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.
F.Y.I. the main reason that this memory leak issue is in the
The stream size does not be changed but the size of the write buffer keep increasing. Because some special case of the
Dec 13, 2018
9 of 10 checks passed
I figured out that this commit will raise redundant errors cause of cleaned
I think that this isn't critical but it keeps leaving error logs. To prevent the redundant error logs, we might add some condition check logic before using