Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing minion result data bug. #50756

Merged
merged 1 commit into from Dec 6, 2018

Conversation

Projects
None yet
3 participants
@GwiYeong
Copy link
Contributor

commented Dec 5, 2018

What does this PR do?

Fix missing minion's return_data problem that occurs timeout exception for api request.
The problem has been occured by timing issue between calling get_events and handling return data.
This problem is same #45874

When salt-api received the minion return data, future's result are setted and handle the data.
If salt-api is receiving another minion return data while handling the data, salt-api missing the data.
Current version of tornado salt-api can miss minions' return events while processing (here) a lastely received minion return event.

Therefore every single return events from salt minions should be subscribed before firing an event.

And I think this commit should be ported to the 2018.3 branch.

What issues does this PR fix or reference?

#45874

Tests written?

No

Commits signed with GPG?

Yes

@cachedout cachedout merged commit b086ff3 into saltstack:2017.7 Dec 6, 2018

8 of 10 checks passed

jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.