Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure ldap passwords are honored #50767

Merged
merged 4 commits into from Dec 5, 2018

Conversation

Projects
None yet
2 participants
@dwoz
Copy link
Contributor

commented Dec 5, 2018

What does this PR do?

Only return a bind from an actual auth attempt.

What issues does this PR fix or reference?

ZD-2993

Previous Behavior

A successful search bind would result in a successful authentication if no username and/or password is provided.

New Behavior

Keep search bind separate and only return bind from an authentication request.

Tests written?

Yes

Commits signed with GPG?

Yes

dwoz added some commits Dec 5, 2018

@dwoz dwoz requested a review from saltstack/team-core as a code owner Dec 5, 2018

@dwoz dwoz requested review from garethgreenaway and cachedout Dec 5, 2018

@cachedout cachedout merged commit dc9414c into saltstack:2018.3 Dec 5, 2018

10 checks passed

WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.