Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add netsh mechanism in the LGPO module #50780

Merged
merged 9 commits into from Dec 10, 2018

Conversation

Projects
None yet
3 participants
@twangboy
Copy link
Contributor

commented Dec 7, 2018

What does this PR do?

Creates a new salt util for netsh and lgpo
Adds the netsh mechanism to the lgpo module
Adds additional functions to the firewall module
Adds support for the Policy': 'Network firewall: Domain: Inbound connections policy

What issues does this PR fix or reference?

saltstack/lock#589
saltstack/lock#479
saltstack/lock#480

Tests written?

No

Commits signed with GPG?

Yes

@twangboy

This comment has been minimized.

Copy link
Contributor Author

commented Dec 7, 2018

@lomeroe @dwoz Would you mind taking a look?

@cachedout cachedout requested review from lomeroe and dwoz Dec 10, 2018

twangboy and others added some commits Dec 7, 2018

Add the netsh mechanism to the lgpo module
Creates a new salt util for netsh and lgpo
Adds the netsh mechanism to the lgpo module
Adds additional functions to the firewall module
Add more policies
Adds more policies
Fixes bug in netsh salt util
Uses __context__ to speed things up
Fixes bug in the state where it was reporting changes when no changes
occurred

@twangboy twangboy force-pushed the twangboy:lgpo_netsh branch from c908767 to f077783 Dec 10, 2018

@twangboy twangboy changed the title [WIP] netsh mechanism in the LGPO module Add netsh mechanism in the LGPO module Dec 10, 2018

@dwoz

dwoz approved these changes Dec 10, 2018

@dwoz dwoz merged commit 9b6b39c into saltstack:2018.3 Dec 10, 2018

10 checks passed

WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
@lomeroe
Copy link
Contributor

left a comment

I know this is already merged, but it looks good to me.

@twangboy

This comment has been minimized.

Copy link
Contributor Author

commented Dec 12, 2018

@lomeroe Sweet, I've already got a PR in to fix a few things, but so far it's been working fine.

@twangboy twangboy deleted the twangboy:lgpo_netsh branch Dec 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.