Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #48801 min, max, inact, and warn changes #50796

Merged
merged 2 commits into from Dec 10, 2018

Conversation

Projects
None yet
3 participants
@dwoz
Copy link
Contributor

commented Dec 8, 2018

What does this PR do?

The _changes method was not properly reporting mindays, maxdays,
inactdays and warndays values. This patch fixes _changes so it reports these changes.

What issues does this PR fix or reference?

#48801

Tests written?

Yes

Commits signed with GPG?

Yes

Fix #48801 min, max, inact, and warn changes
The _changes method was not properlt reporting mindays, maxdays,
inactdays and warndays values

@dwoz dwoz requested a review from cachedout Dec 8, 2018

@dwoz dwoz force-pushed the dwoz:issue48801 branch from c0f3e88 to 935f48b Dec 8, 2018

@dwoz dwoz force-pushed the dwoz:issue48801 branch from 935f48b to 6b95223 Dec 8, 2018

@cachedout cachedout merged commit 12a8447 into saltstack:2018.3 Dec 10, 2018

10 checks passed

WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.