btrfs: add option to not set subvolumes as default #50801

aplanas · 2018-12-10T09:27:07Z

What does this PR do?

When we want to create a subvolume and set is as default, we can
use the set_default parameter. The current code will check, for
already created subvolumes, if it is actually marked as default,
and if not it will be set inside the state.

For composability with other states, we sometimes want to avoid
the re-set of the default flag for already present subvolumes, as
can be that this was change in a later action by another state.

Tests written?

Yes

isbm

I have a very little moment: to avoid nested if. Other then that, looks good.

salt/states/btrfs.py

When we want to create a subvolume and set is as default, we can use the set_default parameter. The current code will check, for already created subvolumes, if it is actually marked as default, and if not it will be set inside the state. For composability with other states, we sometimes want to avoid the re-set of the default flag for already present subvolumes, as can be that this was change in a later action by another state.

saltstack/salt#49668 saltstack/salt#49669 saltstack/salt#49670 saltstack/salt#49803 saltstack/salt#49804 saltstack/salt#50126 saltstack/salt#50175 saltstack/salt#50302 saltstack/salt#50380 saltstack/salt#50396 saltstack/salt#50418 saltstack/salt#50452 saltstack/salt#50473 saltstack/salt#50541 saltstack/salt#50607 saltstack/salt#50635 saltstack/salt#50671 saltstack/salt#50706 saltstack/salt#50725 saltstack/salt#50801 saltstack/salt#50834 saltstack/salt#51074 saltstack/salt#51094 saltstack/salt#51135

* blockdev: fix url from comment saltstack/salt#49668 * Documentation: fix typo in "equivalent" saltstack/salt#49669 * states_pt3: fix rST link format saltstack/salt#49670 * parted: fix _validate_partition_boundary saltstack/salt#49803 * parted: fix the ordering of list command saltstack/salt#49804 * Fix lowpkg.diff documentation and parameter name saltstack/salt#50126 * Add root parameter to useradd, shadow and groupadd saltstack/salt#50175 * cmd: Add root parameter for wait and run states saltstack/salt#50302 * systemd: add optional root parameter saltstack/salt#50380 * service: SUSE is not based on sysvinit anymore saltstack/salt#50396 * Add new chroot module saltstack/salt#50418 * Add new module freezer saltstack/salt#50452 * parted: support variable length output for print saltstack/salt#50473 * btrfs: add all subvolume commands saltstack/salt#50541 * file: update attributes for lsattr and chattr saltstack/salt#50607 * btrfs: add new btrfs state saltstack/salt#50635 * zypper: demote log from error to warning saltstack/salt#50671 * blkid: add search by token saltstack/salt#50706 * mount: add fstab_{present,absent} states saltstack/salt#50725 * btrfs: add option to not set subvolumes as default saltstack/salt#50801 * Add disk_set and disk_toggle functions, and update valid partition flags saltstack/salt#50834 * disk: support setting FAT size for format_ saltstack/salt#51074 * cmdmod: add sysfs into the chroot saltstack/salt#51094 * mount: cache blkid information saltstack/salt#51135

* Add root and no_recommends parameters in the public interface for Zypper and RPM (lowpkg) saltstack/salt#50125 * Add root parameter to useradd, shadow and groupadd saltstack/salt#50175 * cmd: Add root parameter for wait and run states saltstack/salt#50302 * systemd: add optional root parameter saltstack/salt#50380 * Add new chroot module https://github.com/openSUSE/salt/pull/50418 * Add new module freezer saltstack/salt#50452 * btrfs: add all subvolume commands saltstack/salt#50541 * btrfs: add new btrfs state saltstack/salt#50635 * zypper: demote log from error to warning saltstack/salt#50671 * blkid: add search by token saltstack/salt#50706 * mount: add fstab_{present,absent} states saltstack/salt#50725 * btrfs: add option to not set subvolumes as default saltstack/salt#50801 * Add disk_set and disk_toggle functions, and update valid partition flags saltstack/salt#50834 * disk: support setting FAT size for format_ saltstack/salt#51074 * parted: fix set_ valid flags comment. saltstack/salt#51704 * grains/core: ignore HOST_NOT_FOUND errno in fqdns() saltstack/salt#51706 * cmdmod: add 'binds' parameter in run_chroot saltstack/salt#51871 * mount: fix extra -t parameter saltstack/salt#51905 * lvm: be quiet when a pv, lv or vg is not expected saltstack/salt#51929 * linux_lvm: clean error in pvcreate and pvremove saltstack/salt#51954 * blockdev: hide blkid errors when are expected saltstack/salt#51956 * partially unify public functions signature for pkg and lowpkg saltstack/salt#51973 * extmods: add utils directories in sys.path saltstack/salt#52001

ghost self-requested a review December 10, 2018 09:27

isbm reviewed Dec 10, 2018

View reviewed changes

salt/states/btrfs.py Outdated Show resolved Hide resolved

aplanas force-pushed the fix_btrfs branch from 4283b09 to 067482e Compare December 10, 2018 16:40

isbm approved these changes Dec 10, 2018

View reviewed changes

cachedout merged commit e555a67 into saltstack:develop Dec 10, 2018

aplanas deleted the fix_btrfs branch December 11, 2018 09:07

aplanas mentioned this pull request Jan 30, 2019

btrfs: add new btrfs state #51420

Closed

aplanas mentioned this pull request Jan 30, 2019

Backport from develop features required by yomi openSUSE/salt#120

Closed

aplanas mentioned this pull request Oct 11, 2019

(Backport 50635) btrfs: add new btrfs state #54962

Closed

waynew added this to PR needs port to master in PRs to port to master Oct 24, 2019

Ch3LL moved this from PR needs port to master to PR has port to master in PRs to port to master Apr 22, 2020

Ch3LL added the has master-port port to master has been created label Apr 22, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

btrfs: add option to not set subvolumes as default #50801

btrfs: add option to not set subvolumes as default #50801

aplanas commented Dec 10, 2018

isbm left a comment

btrfs: add option to not set subvolumes as default #50801

btrfs: add option to not set subvolumes as default #50801

Conversation

aplanas commented Dec 10, 2018

What does this PR do?

Tests written?

isbm left a comment

Choose a reason for hiding this comment