Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix grains for future windows releases #50844
What does this PR do?
This PR tries to future proof the release and version information displayed in the grains and in the version information for Salt.
Python reports os versions relative to the desktop release. To get the Server version we created a dictionary that correlated the desktop release to the server release. If we detected a server installation then we would use the dictionary to look up the associated server release. Since Microsoft has moved to a rolling release for Windows 10 desktop new server releases no longer have a corresponding desktop release. Windows just released Windows Server 2019 and Salt was still reporting 2016 as the server version.
This PR will base the release and version on the full platform name. Tested against the following data set:
They are detected as follows (osrelease, osfullname):
What issues does this PR fix or reference?
Commits signed with GPG?
Dec 13, 2018
9 of 10 checks passed
@twangboy it seems that after this change the os_release is set to None on Windows Embedded Standard. And because there's logic that expects the os_release grain is set, the salt-minion doesn't start.
I can try. I tried to find out what the product names are for various windows embedded OSes and here's the result of my research:
As a side note, in order to obtain the information above, I haven't created VMs with all these OSes, due to time constraints. Instead, I have analyzed the registry hives from their installers.
What do you think, @twangboy?
And yes, there's also XP which is not currently handled as a version, but I think that is on purpose. Right?