Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Capirca and related modules for ACL config generation #50852

Merged
merged 5 commits into from Jan 15, 2019

Conversation

Projects
None yet
4 participants
@mirceaulinic
Copy link
Member

commented Dec 13, 2018

Since I added these modules in 2017.7.0, Capirca has been released on PyPI,
now available to be installed as a regular Python library.

Besides that, in the past there were various issues due to the way the modules
are interacting with the underlying library, solved by adding a hardcoded list
for the policy term fields. This has caused some issues in the past, and had
to be patches, e.g., db255d3 or
1e74141.
While the changes referenced above are not particularly big, it's tedious to
always keep an eye on Capirca and be aware of what's newly added or changed.
Besides, this may have caused issues for users in the past when using other
Capirca versions.

CC @ankenyr

mirceaulinic and others added some commits Dec 13, 2018

Improve the Capirca and related modules for ACL config generation
Since I added these modules in 2017.7.0, Capirca has been released on PyPI,
now available to be installed as a regular Python library.

Besides that, in the past there were various issues due to the way the modules
are interacting with the underlying library, solved by adding a hardcoded list
for the policy term fields. This has caused some issues in the past, and had
to be patches, e.g., db255d3 or
1e74141.
While the changes referenced above are not particularly big, it's tedious to
always keep an eye on Capirca and be aware of what's newly added or changed.
Besides, this may have caused issues for users in the past when using other
Capirca versions.
Mike Place
@mirceaulinic

This comment has been minimized.

Copy link
Member Author

commented Jan 2, 2019

@saltstack/team-triage this PR is probably blocked due to the linter complaining about: https://jenkinsci.saltstack.com/job/pr-lint/job/PR-50852/6/warnings52Result/new/, however this is the line in cause:

_TERM_FIELDS = {}
- can you please advise?

@mirceaulinic

This comment has been minimized.

Copy link
Member Author

commented Jan 3, 2019

@terminalmage

This comment has been minimized.

Copy link
Contributor

commented Jan 4, 2019

@mirceaulinic I believe that the comment lines are what is tripping up pylint. Try adding a blank line before the comment on line 76, and see if that clears up the lint failure.

mirceaulinic added some commits Jan 4, 2019

@mirceaulinic

This comment has been minimized.

Copy link
Member Author

commented Jan 4, 2019

It looks like this fixed it - thanks @terminalmage!

@mirceaulinic

This comment has been minimized.

Copy link
Member Author

commented Jan 11, 2019

I'm checking in here: @saltstack/team-core is there anything waiting on my end before we can get this in? Thanks!

@thatch45
Copy link
Member

left a comment

I think this looks good to merge

@dwoz

dwoz approved these changes Jan 15, 2019

@dwoz dwoz merged commit 4a12c5f into saltstack:2017.7 Jan 15, 2019

10 checks passed

WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.