Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get searchdomain in Ubuntu 12+ (2017.7) #50858

Conversation

Projects
None yet
3 participants
@jasonarewhy
Copy link
Contributor

commented Dec 13, 2018

resolves #39151

What does this PR do?

The get_networking_settings function checks whether the osrelease is Ubuntu 12+ in order to skip checking /etc/default/networking, but _parse_networking_settings doesn't. Because get_networking_settings was not parsing resolv.conf for search, Ubuntu 12+ systems would result in re-applying network settings every highstate.

What issues does this PR fix or reference?

#39151

Previous Behavior

Every highstate produced the following and restarted networking.service:

----------
          ID: network-system
    Function: network.system
      Result: True
     Comment: Global network settings are up to date.
     Started: 19:21:58.926859
    Duration: 4126.608 ms
     Changes:
              ----------
              network_settings:
                  ---
                  +++
                  @@ -1,2 +1,3 @@
                   NETWORKING=yes

                   HOSTNAME=hostname

                  +SEARCH=domain.tld

New Behavior

No changes during highstate

@jasonarewhy jasonarewhy changed the title get searchdomain in Ubuntu 12+ get searchdomain in Ubuntu 12+ (2017.7) Dec 13, 2018

@jasonarewhy jasonarewhy force-pushed the jasonarewhy:bugfix-2017.7/ubuntu-networking-searchdomain branch from 6f92381 to 29522f3 Dec 17, 2018

@jasonarewhy jasonarewhy force-pushed the jasonarewhy:bugfix-2017.7/ubuntu-networking-searchdomain branch from 29522f3 to 69d25aa Dec 17, 2018

@garethgreenaway garethgreenaway merged commit 8a76a19 into saltstack:2017.7 Jan 8, 2019

9 of 10 checks passed

jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details

@jasonarewhy jasonarewhy deleted the jasonarewhy:bugfix-2017.7/ubuntu-networking-searchdomain branch Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.