Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2018.3] Fixes for key_cache and python3 #50859

Merged

Conversation

Projects
None yet
2 participants
@garethgreenaway
Copy link
Member

commented Dec 13, 2018

What does this PR do?

When reading and writing the key cache file, when using Python3, ensuring the file is read & written in binary mode.

What issues does this PR fix or reference?

#50850

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

When reading and writing the key cache file, when using Python3, ensu…
…ring the file is read & written in binary mode.

@garethgreenaway garethgreenaway requested a review from saltstack/team-core as a code owner Dec 13, 2018

@thatch45 thatch45 merged commit 216fa14 into saltstack:2018.3 Dec 13, 2018

10 checks passed

WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint Python lint test has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.